-
-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: multiple user/password authentication #55
base: master
Are you sure you want to change the base?
Conversation
Hi, @alexng353! Long living request 👍🏻 Thank for you contribution, lets talk about userlist fetaere before merge it. What about making yaml-based format and using ENV var for using userpass file or event config-file? Most moder schedullers can generate secretfiles or configs with generating secretfiles. We can do config file at all, with userlist section. For scaling features scenario, in future, we can have one entrypoint file for different cases, I can contribute and finalize this idea. |
If you would like to keep this project working without a database, the best way is probably to use a config file. Personally, if you were to do a config file for this project, I would prefer to have as many possible formats supported as possible, TOML, YAML, JSON, Apple PKL, etc all supported and parsing into one struct at start time. I'm not sure what an Considering how this project is primarily docker-based, I would think that continuing to support passing a multi-user configuration through an environment variable is likely a good idea. I wanted to ask you if it would be a good idea to allow passing username-password combinations as follows: CREDENTIALS=username:password;username2:password2 And then manually parsing the string. I opted to use JSON since I wanted to support as wide a range of characters as possible. Sidenote: Don't mind the Edit1: What are |
Yea, i think |
Allows user to provide multiple user/password objects as a JSON object via the
PROXY_CREDENTIALS
environment variable.Recommended to squoosh your JSON so that it's easier to copy and paste into a command prompt. You can also provide a
.env
file via the--env-file
flag which makes providing this JSON object a little easier.I am unsure if this is the best way to pass credentials, but given the string-only limitations of environment variables, this is the best I could think of.
fixes: #4